[
https://issues.apache.org/jira/browse/HADOOP-19805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056893#comment-18056893
]
ASF GitHub Bot commented on HADOOP-19805:
-----------------------------------------
steveloughran opened a new pull request, #8231:
URL: https://github.com/apache/hadoop/pull/8231
### Description of PR
After creating an AWS signer for signing requests (s3, sts etc), if it
implements Configurable, pass in the config.
### How was this patch tested?
New test asserts in existing unit and s3 integration tests
Tested against s3 london.
* all miniyarn clusters are refusing to play. This is branch-3.4; I shall do
a trunk PR to test there.
* STS failure tests are failing with different errors that aren't caught by
the intercept() (malformed json). Changes in the SDK which need test changes to
make "go away".
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [X] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [ ] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [ ] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> When creating a signer, if it is Configurable, set its config
> -------------------------------------------------------------
>
> Key: HADOOP-19805
> URL: https://issues.apache.org/jira/browse/HADOOP-19805
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.4.3
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
>
> When creating a signer for s3 (or another service), if it is Configurable,
> call setConf() on it.
> This comes from me wiring s3a up to iceberg RestCatalog; it's pretty
> convoluted to connect a signer in the sdk to its owner fs otherwise, and so
> get the configuration for that bucket. Trivial change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
