[ 
https://issues.apache.org/jira/browse/HADOOP-19810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057247#comment-18057247
 ] 

ASF GitHub Bot commented on HADOOP-19810:
-----------------------------------------

aajisaka commented on PR #8239:
URL: https://github.com/apache/hadoop/pull/8239#issuecomment-3869266282

   @pan3793 Writable object is usually small, so would you also benchmark 
against smaller array size like 
https://issues.apache.org/jira/browse/HADOOP-14313? I want to check there's no 
regression in 128, 256, 512, 1028, 2048.
   
   > BytesComparatorBenchmark.hadoopDiffLast        64    ss    5  ≈ 10⁻⁴       
     s/op
   > BytesComparatorBenchmark.jdkDiffLast           64    ss    5  ≈ 10⁻⁴       
     s/op
   
   The above numbers are very small. How can we compare these?




> Replace FastByteComparisons with JDK Arrays.compareUnsigned
> -----------------------------------------------------------
>
>                 Key: HADOOP-19810
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19810
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>            Reporter: Cheng Pan
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to