Hean-Chhinling commented on code in PR #8222:
URL: https://github.com/apache/hadoop/pull/8222#discussion_r2782387284
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/ZKConfigurationStore.java:
##########
@@ -265,9 +266,37 @@ private boolean createNewZkPath(String path) throws
Exception {
@VisibleForTesting
protected byte[] getZkData(String path) throws Exception {
- return zkManager.getData(path);
+ // Should a 'yarn resourcemanager -format-state-store' command is issued
+ // while one of the RM is in a starting state, there is a time period
+ // when the /confstore/CONF_STORE path does not exist, on a different
Review Comment:
I am not really clear of the phrase below:
> "on a different occasion the confstore is being written"
I would phrase it like the following:
> while one of the RM is in a starting state, there is a time period
> when the /confstore/CONF_STORE path does not exist or the ZkData has not
fully been written
> then the getZkData method returns a null value causing the RM to fail.
> To prevent this, added a re-try mechanism before giving up.
Please let me know what do you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
