[
https://issues.apache.org/jira/browse/HADOOP-19807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057408#comment-18057408
]
ASF GitHub Bot commented on HADOOP-19807:
-----------------------------------------
cnauroth commented on code in PR #8235:
URL: https://github.com/apache/hadoop/pull/8235#discussion_r2783884362
##########
start-build-env.sh:
##########
@@ -98,15 +102,15 @@ ENV HOME="${DOCKER_HOME_DIR}"
UserSpecificDocker
-#If this env varible is empty, docker will be started
+# If this env variable is empty, docker will be started
# in non interactive mode
DOCKER_INTERACTIVE_RUN=${DOCKER_INTERACTIVE_RUN-"-i -t"}
# By mapping the .m2 directory you can do an mvn install from
# within the container and use the result on your normal
# system. And this also is a significant speedup in subsequent
# builds because the dependencies are downloaded only once.
-docker run --rm=true $DOCKER_INTERACTIVE_RUN \
+docker run "${DOCKER_PLATFORM_ARGS[@]}" --rm=true ${DOCKER_INTERACTIVE_RUN} \
Review Comment:
Would you mind putting quotes around `"${DOCKER_INTERACTIVE_RUN}"`? That
will give us a completely clean shellcheck on this file.
> Enable cross-platform support for dev container
> -----------------------------------------------
>
> Key: HADOOP-19807
> URL: https://issues.apache.org/jira/browse/HADOOP-19807
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.5.0
> Reporter: Cheng Pan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
