[
https://issues.apache.org/jira/browse/HADOOP-19811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057442#comment-18057442
]
ASF GitHub Bot commented on HADOOP-19811:
-----------------------------------------
cnauroth opened a new pull request, #8243:
URL: https://github.com/apache/hadoop/pull/8243
### Description of PR
Add a relocation rule to the maven-shade-plugin configuration to cover
`io.opentelemetry`. Thank you to @pan3793 for reporting the problem.
### How was this patch tested?
Apply the patch and run:
```
mvn clean install -DskipTests
```
Inspect the built jar to verify that the OpenTelemetry classes are now
relocated under `com.google.cloud.hadoop.repackaged.ossgcs.io.opentelemetry`:
```
cnauroth@30ef96c80aa8:~/hadoop$ jar tf
hadoop-cloud-storage-project/hadoop-gcp/target/hadoop-gcp-3.5.0-SNAPSHOT.jar |
grep 'io/opentelemetry/api' | head
com/google/cloud/hadoop/repackaged/ossgcs/io/opentelemetry/api/
com/google/cloud/hadoop/repackaged/ossgcs/io/opentelemetry/api/DefaultOpenTelemetry.class
com/google/cloud/hadoop/repackaged/ossgcs/io/opentelemetry/api/GlobalOpenTelemetry$ObfuscatedOpenTelemetry.class
com/google/cloud/hadoop/repackaged/ossgcs/io/opentelemetry/api/GlobalOpenTelemetry.class
com/google/cloud/hadoop/repackaged/ossgcs/io/opentelemetry/api/OpenTelemetry.class
com/google/cloud/hadoop/repackaged/ossgcs/io/opentelemetry/api/package-info.class
com/google/cloud/hadoop/repackaged/ossgcs/io/opentelemetry/api/baggage/
com/google/cloud/hadoop/repackaged/ossgcs/io/opentelemetry/api/baggage/AutoValue_ImmutableEntry.class
com/google/cloud/hadoop/repackaged/ossgcs/io/opentelemetry/api/baggage/AutoValue_ImmutableEntryMetadata.class
com/google/cloud/hadoop/repackaged/ossgcs/io/opentelemetry/api/baggage/Baggage.class
```
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [X] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [ ] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [ ] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> hadoop-gcp does not relocate shaded OpenTelemetry dependencies
> --------------------------------------------------------------
>
> Key: HADOOP-19811
> URL: https://issues.apache.org/jira/browse/HADOOP-19811
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/gcs
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Blocker
>
> The hadoop-gcp sub-module intends to produce a jar with a completely shaded
> and relocated set of internal dependencies. Currently, the OpenTelemetry
> classes are not relocated, which creates a risk of version conflicts with
> downstream projects. Thank you to [~chengpan] for reporting this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
