[
https://issues.apache.org/jira/browse/HADOOP-19811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057781#comment-18057781
]
ASF GitHub Bot commented on HADOOP-19811:
-----------------------------------------
pan3793 commented on code in PR #8243:
URL: https://github.com/apache/hadoop/pull/8243#discussion_r2792168265
##########
hadoop-cloud-storage-project/hadoop-gcp/pom.xml:
##########
@@ -336,9 +346,14 @@
<includes>
<include>io.grpc.**</include>
<include>io.opencensus.**</include>
+ <include>io.opentelemetry.**</include>
<include>io.perfmark.**</include>
</includes>
</relocation>
+ <relocation>
+ <pattern>META-INF/versions/9/io/opentelemetry</pattern>
Review Comment:
quite hacky and fragile approach, easy to break silently once opentelemetry
creates more versioned classes ...
after a closer look, the `opentelemetry-sdk-common-1.49.0.jar` seems to be a
malformed multi-release jar, it actually misses the `versions/9` sub dir, and
it gets removed in the latest version 1.59.0, maybe we can just upgrade to
1.59.0? then we don't need to worry about it
> hadoop-gcp does not relocate shaded OpenTelemetry dependencies
> --------------------------------------------------------------
>
> Key: HADOOP-19811
> URL: https://issues.apache.org/jira/browse/HADOOP-19811
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/gcs
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Blocker
> Labels: pull-request-available
>
> The hadoop-gcp sub-module intends to produce a jar with a completely shaded
> and relocated set of internal dependencies. Currently, the OpenTelemetry
> classes are not relocated, which creates a risk of version conflicts with
> downstream projects. Thank you to [~chengpan] for reporting this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
