[
https://issues.apache.org/jira/browse/HADOOP-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058995#comment-18058995
]
ASF GitHub Bot commented on HADOOP-18898:
-----------------------------------------
eciuca commented on PR #8253:
URL: https://github.com/apache/hadoop/pull/8253#issuecomment-3912407882
Thanks for the review, @hadoop-yetus.
**Re: trunk failures (mvninstall, compile, mvnsite, javadoc):** These all
fail on trunk due to the broken `io.github.ascopes:protobuf-maven-plugin`
configuration in `hadoop-yarn-csi`. Our patch fixes this — all "Patch Compile
Tests" pass (mvninstall ✅, compile ✅, mvnsite ✅, unit ✅, shadedclient ✅).
**Re: javadoc warnings (26 new):** These are **pre-existing**
missing-comment warnings in `hadoop-yarn-csi` source files (e.g.
`CsiClient.java`, `CsiGrpcClient.java`, `ProtoTranslator.java`). They appear as
"new" only because trunk cannot build `hadoop-yarn-csi` at all (protobuf
failure → 0 baseline warnings). Once our patch fixes the build, javadoc can run
and surfaces these pre-existing issues. None of these warnings are in files
touched by this PR.
**Re: test4tests:** This PR only modifies Maven `pom.xml` build
configuration (argLine propagation and protobuf plugin parameters). No new
tests are needed — the fix is verified by the successful compilation and unit
test execution in the patch phase.
> Add argLine configuration to maven-surefire-plugin
> --------------------------------------------------
>
> Key: HADOOP-18898
> URL: https://issues.apache.org/jira/browse/HADOOP-18898
> Project: Hadoop Common
> Issue Type: Task
> Components: build
> Reporter: Bruno Ramirez
> Priority: Major
> Labels: pull-request-available
>
> Child jvms spawned by the maven do not have add-opens command line options.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
