[
https://issues.apache.org/jira/browse/HADOOP-19802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18060209#comment-18060209
]
ASF GitHub Bot commented on HADOOP-19802:
-----------------------------------------
manika137 commented on code in PR #8229:
URL: https://github.com/apache/hadoop/pull/8229#discussion_r2839074421
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/utils/DelegationSASGeneratorVersionJuly5.java:
##########
@@ -131,6 +131,10 @@ public String getDelegationSAS(String accountName, String
containerName, String
sr = "d";
sdd = path.equals(ROOT_PATH)? "0":
Integer.toString(StringUtils.countMatches(path, "/"));
break;
+ case SASTokenProvider.LIST_CONTAINERS_OPERATION:
+ sp = "l"; // list
+ sr = "s"; // service
Review Comment:
sr would be either be b or c. we dont have support for service (s) in
delegation SAS
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/utils/DelegationSASGeneratorVersionJuly5.java:
##########
@@ -131,6 +131,10 @@ public String getDelegationSAS(String accountName, String
containerName, String
sr = "d";
sdd = path.equals(ROOT_PATH)? "0":
Integer.toString(StringUtils.countMatches(path, "/"));
break;
+ case SASTokenProvider.LIST_CONTAINERS_OPERATION:
+ sp = "l"; // list
+ sr = "s"; // service
Review Comment:
Would need a test around this
> ABFS: Remove SDK dependency in hadoop-azure
> -------------------------------------------
>
> Key: HADOOP-19802
> URL: https://issues.apache.org/jira/browse/HADOOP-19802
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.4.2
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
>
> Remove use of SDK from hadoop-azure
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
