[
https://issues.apache.org/jira/browse/HADOOP-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403831#comment-13403831
]
Junping Du commented on HADOOP-8472:
------------------------------------
Hi Nicholas,
> If the refactoring is simple and easy, do it. Otherwise, we should focus on
> the main code but not waste our energy on the code style of the tests.
Agree. In fact, I try to refactor for some test cases but it looks odd to be a
test code if we want to reuse everything in parent class (which means we will
add a lot of hooks in parent testcases and override it in sub-class). I think
current test implementation is explicit for reading and understanding the test
flow. So in latest patch (v4), I only fix one java doc issue and do minimum
refactoring on test.
> Implementation of ReplicaPlacementPolicyNodeGroup to support 4-layer network
> topology
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8472
> URL: https://issues.apache.org/jira/browse/HADOOP-8472
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha, io
> Affects Versions: 1.0.0, 2.0.0-alpha
> Reporter: Junping Du
> Assignee: Junping Du
> Attachments:
> HADOOP-8472-BlockPlacementPolicyWithNodeGroup-impl-v2.patch,
> HADOOP-8472-BlockPlacementPolicyWithNodeGroup-impl-v3.patch,
> HADOOP-8472-BlockPlacementPolicyWithNodeGroup-impl-v4.patch,
> HADOOP-8472-BlockPlacementPolicyWithNodeGroup-impl.patch
>
>
> A subclass of ReplicaPlacementPolicyDefault, ReplicaPlacementPolicyNodeGroup
> was developed along with unit tests to support the four-layer hierarchical
> topology.
> The replica placement strategy used in ReplicaPlacementPolicyNodeGroup
> virtualization is almost the same as the original one. The differences are:
> 1. The 3rd replica will be off node group of the 2nd replica
> 2. If there is no local node available, the 1st replica will be placed on a
> node in the local node group.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
