[
https://issues.apache.org/jira/browse/HADOOP-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18062046#comment-18062046
]
ASF GitHub Bot commented on HADOOP-10579:
-----------------------------------------
aajisaka commented on PR #8259:
URL: https://github.com/apache/hadoop/pull/8259#issuecomment-3982572320
> > * Would you add a test case to make sure multiple options are handled
correctly? For example: `-mtime 10 -regex *.parquet`
>
> I think it’s `Find.java` and `And.java` that ensures multiple expressions
work correctly, and `TestFind.java` and `TestAnd.java` that tests this
behavior. Since `processOptionsNoop`, `processOptionsA` and `processOptionsAnd`
already exist in `TestFind.java`, and we already have `TestAnd.java`, I believe
their existing tests provide sufficient coverage. Do you think any additional
tests are necessary?
Thank you for the detail. Now I think additional tests are unnecessary.
> > * Would you document the new expressions in FileSystemShell.md?
>
> I documented it in this commit
[a046ee5](https://github.com/apache/hadoop/commit/a046ee5fd6efc65c1668b9897186ca0af327e449).
>
> > * Would you fix the checkstyle issues and trailing whitespaces warned by
the CI?
>
> I fixed it in the following commit.
>
> *
[53d5c90](https://github.com/apache/hadoop/commit/53d5c90196f06c7ffef4bd08addf0f5a01925693)
> *
[a424a11](https://github.com/apache/hadoop/commit/a424a11b4b462829e8f986b7ac288dfdbb53a6db)
> *
[81fb503](https://github.com/apache/hadoop/commit/81fb503b97e2f8210f0940caa676d7a139888a50)
Thanks
> Find command - add match expressions to find command
> ----------------------------------------------------
>
> Key: HADOOP-10579
> URL: https://issues.apache.org/jira/browse/HADOOP-10579
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Jonathan Allen
> Assignee: Hiroki Egawa
> Priority: Minor
> Labels: pull-request-available
> Attachments: HADOOP-10579.patch
>
>
> Add match expressions to the find command created under HADOOP-8989, e.g.:
> - atime
> - empty
> - group
> - mtime
> - newer
> - nogroup
> - nouser
> - perm
> - regex
> - size
> - user
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
