steveloughran commented on PR #8048:
URL: https://github.com/apache/hadoop/pull/8048#issuecomment-3997533221

   ok, you've got yetus nice and quiet, and done the cloud storage tests, just 
a couple of checkstyles remaining
   
   ```
   
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFileSystemIsolatedClassloader.java:52:
    public CustomCredentialsProvider() {:5: Redundant 'public' modifier. 
[RedundantModifier]
   
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFileSystemIsolatedClassloader.java:184:
      mapOf(Constants.AWS_S3_CLASSLOADER_ISOLATION, "false",:7: 'mapOf' has 
incorrect indentation level 6, expected level should be 8. [Indentation
   ```
   
   +1 pending you addressing those nits


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to