RomanVlasenko commented on PR #50: URL: https://github.com/apache/hadoop-thirdparty/pull/50#issuecomment-4018670138
@pan3793 > jspecify won't be used at runtime. can we exclude it? From Guava's own documentation: > In rare cases, you may also need to include the jspecify dependency at runtime. Specifically, if you run under JDK 8 and you use reflection on Guava types, you may encounter [JDK-8152174](https://bugs.openjdk.org/browse/JDK-8152174). To avoid this, you can upgrade to JDK 9+, or you can stop excluding the jspecify dependency. Source: https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies I think it's safer to keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
