kokonguyen191 commented on PR #8448: URL: https://github.com/apache/hadoop/pull/8448#issuecomment-4395500039
Hi @hfutatzhanghb @KeeProMise, I also thought about using `DFS_ROUTER_ASYNC_RPC_MAX_ASYNCCALL_PERMIT_KEY` as an alternative control mechanic but there were 2 things that didn't really sit well with me: - Unless DFS_ROUTER_FAIRNESS_ACQUIRE_TIMEOUT = 0 (which kinda removes a big chunk of the purpose of the fairness controller), there is a wait time for permit acquisition, and the async handler queue can still get flooded. Though, even with zero wait time, it's still possible to flood the queue, just more difficult. - I think the fairness controller shouldn't be the OOM preventive solution since that's not its intended usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
