ajfabbri commented on code in PR #8467: URL: https://github.com/apache/hadoop/pull/8467#discussion_r3236601708
########## .github/workflows/tmpl_cloud_aws.yml: ########## @@ -0,0 +1,230 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +name: s3a integration +on: + workflow_call: + inputs: + java: + required: false + type: string + default: 17 + toolchain_branch: + required: false + type: string + description: Branch to use for toolchain image build + default: trunk + os: + required: false + type: string + description: OS for container to run the build in + default: ubuntu_24 + runner_os: + required: false + type: string + description: OS tag for runner (e.g., Linux, ubuntu-24.04) + default: ubuntu_24.04 + +# Security: Minimal defaults for workflow. +permissions: {} + +concurrency: + group: >- + cloud-aws + ${{ github.workflow }} + ${{ github.repository == 'apache/hadoop' && github.run_id || github.ref }} + ${{ inputs.java }} + ${{ inputs.toolchain_branch }} + ${{ inputs.os }} + cancel-in-progress: true + +env: + BUCKET_NAME: hadoop-ci + +jobs: + precondition: + runs-on: ${{ inputs.runner_os }} + outputs: + build_image_url: ${{ steps.img.outputs.build_image_url }} + steps: + - uses: actions/checkout@v6 + with: + # Full fetch so build image URL can be computed for any branch + fetch-depth: 0 + - uses: ./.github/actions/build_image_url + id: img + with: + os: ${{ inputs.os }} + branch: ${{ inputs.toolchain_branch }} + - name: debug base_image_url + run: | + echo "precondition url: ${{ steps.img.outputs.build_image_url }}" + + build-image: + name: Toolchain image (JDK${{ inputs.java }}, ${{ inputs.os }}-${{ inputs.toolchain_branch }}) + runs-on: ${{ inputs.runner_os }} + needs: [ precondition ] + permissions: + packages: write + outputs: + uid: ${{ steps.build_img.outputs.uid }} + steps: + - name: debug build url + run: | + echo "Build image URL: ${{ needs.precondition.outputs.build_image_url }}" + - uses: actions/checkout@v6 + - uses: ./.github/actions/build_image Review Comment: My primary concern is speed and efficiency. If I push an update to my S3A PR, there is no reason it should take more than 10-15 minutes. I also think factoring out common components is better than one mega-workflow. Especially because developing these workflows takes time, and this allows us to work in parallel. I'm open to iterating and evolving this over time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
