[ 
https://issues.apache.org/jira/browse/HADOOP-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409187#comment-13409187
 ] 

Matt Foley commented on HADOOP-8399:
------------------------------------

We have two competing versions of this patch, the one here in HADOOP-8399, and 
a pair of patches in HADOOP-8166.  I have compared them and found this one to 
be superior in terms of match to current branch-1.1.

HADOOP-8399 patches files: build.xml, forrest.properties, test-patch.sh
hadoop-8166 patches files: build.xml, do-release-build, forrest.properties, 
test-patch.sh
The changes to build.xml and forrest.properties are equivalent.
The file cloudera/do-release-build does not exist in Apache code.
The changes to test-patch.sh differ in several ways, but seem to match the 
branch-1.1 code better in HADOOP-8399.

In particular, HADOOP-8399 applies smoothly to test-patch.sh, while HADOOP-8166 
fails 3 of 9 chunks.  Furthermore, after applying HADOOP-8399, all instances of 
'java5' are gone, which makes all the substantive differences between the two 
patches irrelevant.

+1 on this patch.  Committing to branch-1.1 and branch-1.  Marking HADOOP-8166 
as duplicate.


                
> Remove JDK5 dependency from Hadoop 1.0+ line
> --------------------------------------------
>
>                 Key: HADOOP-8399
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8399
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.0.2
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 1.1.0
>
>         Attachments: HADOOP-8399.patch
>
>
> This issues has been fixed in Hadoop starting from 0.21 (see HDFS-1552).
> I propose to make the same fix for 1.0 line and get rid of JDK5 dependency 
> all together.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to