charlesconnell commented on PR #8466: URL: https://github.com/apache/hadoop/pull/8466#issuecomment-4544569163
@steveloughran Thank you for the merge. The backport is open at https://github.com/apache/hadoop/pull/8516. The code around line 1292 could be improved to be easier to reason about, but I don't think there is a byte array leak there. The `DFSPacket` aliased as `one` stays in the `ackQueue` until 1288. I think we can assume nothing can fail between lines 1288 when it's taken from the `ackQueue` and line 1292 when it's freed. Any packets that are in the `ackQueue` will be freed eventually when `closeInternal()` runs, which would happen if there were failures elsewhere in the `work()` loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
