[ 
https://issues.apache.org/jira/browse/HADOOP-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18088010#comment-18088010
 ] 

ASF GitHub Bot commented on HADOOP-19917:
-----------------------------------------

K0K0V0K commented on code in PR #8544:
URL: https://github.com/apache/hadoop/pull/8544#discussion_r3389259332


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -1180,7 +1180,7 @@ protected String appendSASTokenToQuery(String path,
       } catch (Exception ex) {
         throw new SASTokenProviderException(String.format(
             "Failed to acquire a SAS token for %s on %s due to %s", operation, 
path,
-            ex.toString()));
+            ex.toString()), ex);

Review Comment:
   that can be a regression, maybe some one already built test / logic on how 
the exception msg looks like





> Add cause to exception in AbfsClient if SASTokenProvider failed
> ---------------------------------------------------------------
>
>                 Key: HADOOP-19917
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19917
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: hadoop-tools
>    Affects Versions: 3.5.0
>            Reporter: Bence Kosztolnik
>            Assignee: Bence Kosztolnik
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently in the *org.apache.hadoop.fs.azurebfs.services.AbfsClient* if theĀ 
> sasTokenProvider throws an exception, than the root cause wont be visible in 
> the logs.
> The SasTokenProvider can be a third party entity (for example Ranger 
> implementation) so debugging can be challenging in these situation.
> Example log snippet
> {code:java}
> Failed to acquire a SAS token for get-status on [[PATH]] due to 
> org.apache.hadoop.security.AccessControlException: 
> org.apache.ranger.raz.intg.RangerRazException: null responseĀ {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to