K0K0V0K commented on PR #8547: URL: https://github.com/apache/hadoop/pull/8547#issuecomment-4709807027
Thanks @zhengchenyu for the change! Overall, this looks good to me. One thing that came to mind: if I understand correctly, the `/ws/v1/cluster/metrics` endpoint currently has a fairly predictable response size and response time. With this change, both could become dependent on the number of partitions in the cluster. As far as I know, a single ResourceManager can handle around 10,000 NodeManagers. In a hypothetical worst-case scenario where each NodeManager belongs to a different partition, could you measure how the response time is affected? I’m not familiar with your use case, but have you considered exposing this information through a separate endpoint instead? For example, something like `/ws/v1/cluster/partitions/metrics` or` /ws/v1/cluster/partition-metrics` might avoid introducing any regression in the response size or latency of the existing /ws/v1/cluster/metrics endpoint while still making the additional data available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
