kokonguyen191 commented on code in PR #8540:
URL: https://github.com/apache/hadoop/pull/8540#discussion_r3426918628
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/RBFMetrics.java:
##########
@@ -379,6 +387,19 @@ public String getRouters() {
return JSON.toString(info);
}
+ private static String guessRouterWebAddress(String adminAddress, int
webPort) {
Review Comment:
Updated methods to remove guess naming. If we want fully correct per router
web address, router state store has to store those data (which currently it
does not). I think for a simple web UI improvement and for most deployments
with a consistent config for all routers in a cluster, this is a fair
compromise to arrive at
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
