steveloughran commented on code in PR #8561:
URL: https://github.com/apache/hadoop/pull/8561#discussion_r3476329252
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestOpenFileWithLocatedBlocks.java:
##########
@@ -66,12 +63,13 @@ public class TestOpenFileWithLocatedBlocks {
private static final EnumSet<CreateEncryptionZoneFlag> NO_TRASH =
EnumSet.of(CreateEncryptionZoneFlag.NO_TRASH);
- private MiniDFSCluster cluster;
- private DistributedFileSystem fs;
- private Configuration conf;
+ private static MiniDFSCluster cluster;
+ private static DistributedFileSystem fs;
+ private static Configuration conf;
+ private static Path ezPath;
- @BeforeEach
- public void setUp() throws IOException {
+ @BeforeAll
+ public static void setUp() throws Exception {
Review Comment:
very minor, just call this "setupCluster" and "teardownCluster".
setUp/tearDown have were the per method calls in junit1, and it's easy for
people who have read too many tests to get mixed up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
