[
https://issues.apache.org/jira/browse/HADOOP-19931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18094031#comment-18094031
]
ASF GitHub Bot commented on HADOOP-19931:
-----------------------------------------
steveloughran commented on PR #8584:
URL: https://github.com/apache/hadoop/pull/8584#issuecomment-4894100028
reviewed the whole class; it is all four-char indented at the base...the
only way to get the formatting right would be reformat the entire file. Which I
don't intend to do.
- fixed javadoc warnings
- cut a needless template type
> Summary: SSLHostnameVerifier subject CN parsing is too brittle
> ---------------------------------------------------------------
>
> Key: HADOOP-19931
> URL: https://issues.apache.org/jira/browse/HADOOP-19931
> Project: Hadoop Common
> Issue Type: Improvement
> Components: net
> Affects Versions: 3.5.0, 3.4.3
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Labels: pull-request-available
>
> Certificates.getCNs() extracts CNs by string-tokenising
> getSubjectX500Principal().toString() on commas and matching CN=.
> This is too brittle.
> Parse the subject with LdapName and take CNs from actual CN RDNs instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
