Hexiaoqiao commented on code in PR #8335:
URL: https://github.com/apache/hadoop/pull/8335#discussion_r3533316942
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/command/PlanCommand.java:
##########
@@ -250,11 +250,16 @@ static private void printToScreen(List<NodePlan> plans) {
}
/**
- * Sets user specified plan parameters.
+ * Sets user specified plan parameters (bandwidth, maxError,
tolerancePercent).
+ * tolerancePercent is read from config so the plan propagated to the
DataNode
+ * uses the same value (HDFS-17872).
*
* @param plans - list of plans.
*/
private void setPlanParams(List<NodePlan> plans) {
+ int tolerancePercent = getConf().getInt(
Review Comment:
We need to check if `tolerancePercent` is not greater than 0 here. Others
looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
