ferdelyi opened a new pull request, #8621:
URL: https://github.com/apache/hadoop/pull/8621
…endently of -DskipTests
The hadoop-yarn-applications-catalog-webapp module runs a
jasmine-maven-plugin test that drives a PhantomJS browser. In headless build
environments PhantomJS cannot start and the plugin fails with
UnreachableBrowserException. Because this is a plugin-execution failure rather
than a Surefire test failure, -Dmaven.test.failure.ignore=true does not
suppress it and it fails the build. The jasmine config previously hardcoded its
skip flag to ${skipTests}, so the only escape hatch was -DskipTests, which
skips every test in the module.
Introduce a skipJasmineTests property defaulting to ${skipTests} and bind
the plugin's <skipJasmineTests> to it. Default behavior is unchanged; a
headless build can pass -DskipJasmineTests=true to skip only the browser-driven
tests while still compiling and covering the rest of the module. Build-config
change only; no production code affected.
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
### How was this patch tested?
### For code changes:
- [ x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [ x] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [ x] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
