anshuksi282-ksolves commented on PR #8622: URL: https://github.com/apache/hadoop/pull/8622#issuecomment-5044594528
Hi all, Requesting a review whenever you get a chance. This PR picks up HADOOP-18896 from where #6064 (@teamconfx) left off — it went stale without a unit test. I've added a unit test (`TestFSOutputSummer#testLargeBytesPerChecksumOverflow`) that reproduces the original `NegativeArraySizeException` without the fix, and verifies the fix resolves it with a clean `IllegalArgumentException` instead. I'm new to contributing to Hadoop, so please let me know if any changes are needed. Thanks in advance! cc: @ayushtkn @dineshchitlangia @brahmareddybattula @pjfanning @slfan1989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
