[
https://issues.apache.org/jira/browse/HADOOP-18896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18098123#comment-18098123
]
ASF GitHub Bot commented on HADOOP-18896:
-----------------------------------------
anshuksi282-ksolves commented on PR #8622:
URL: https://github.com/apache/hadoop/pull/8622#issuecomment-5044594528
Hi all,
Requesting a review whenever you get a chance. This PR picks up HADOOP-18896
from where #6064 (@teamconfx) left off — it went stale without a unit test.
I've added a unit test (`TestFSOutputSummer#testLargeBytesPerChecksumOverflow`)
that reproduces the original `NegativeArraySizeException` without the fix, and
verifies the fix resolves it with a clean `IllegalArgumentException` instead.
I'm new to contributing to Hadoop, so please let me know if any changes are
needed. Thanks in advance!
cc: @ayushtkn @dineshchitlangia @brahmareddybattula @pjfanning @slfan1989
> NegativeArraySizeException thrown in FSOutputSummer.java given large
> file.bytes-per-checksum
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-18896
> URL: https://issues.apache.org/jira/browse/HADOOP-18896
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.3.6
> Reporter: rstest
> Priority: Critical
> Labels: pull-request-available
>
> Buffer size of FSOutputSummer equals to `file.bytes-per-checksum` times
> `BUFFER_NUM_CHUNKS`. A large `file.bytes-per-checksum` causes buffer size to
> overflow and crash with NegativeArraySizeException.
> To reproduce:
> 1. set `file.bytes-per-checksum` to 238609295
> 2. `mvn surefire:test
> -Dtest=org.apache.hadoop.hdfs.TestDecommissionWithStriped#testFileSmallerThanOneStripe`
> We created a PR that provides a fix which checks the buffer size is positive
> after multiplying `file.bytes-per-checksum` with `BUFFER_NUM_CHUNKS`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
