[
https://issues.apache.org/jira/browse/HADOOP-19952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101649#comment-18101649
]
ASF GitHub Bot commented on HADOOP-19952:
-----------------------------------------
K0K0V0K commented on code in PR #8655:
URL: https://github.com/apache/hadoop/pull/8655#discussion_r3710995298
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java:
##########
@@ -268,7 +269,14 @@ public void init(SSLFactory.Mode mode)
conf.get(resolvePropertyName(mode, SSL_KEYSTORE_TYPE_TPL_KEY),
DEFAULT_KEYSTORE_TYPE);
- if (requireClientCert || mode == SSLFactory.Mode.SERVER) {
+ String keystoreLocationProperty =
+ resolvePropertyName(mode, SSL_KEYSTORE_LOCATION_TPL_KEY);
+ String keystoreLocation = conf.get(keystoreLocationProperty, "");
+ boolean keystoreFilePresent = !keystoreLocation.isEmpty()
Review Comment:
Maybe a Warning log would be nice if file not found, but configured.
> Load client keystore when ssl.client.keystore.location is set
> -------------------------------------------------------------
>
> Key: HADOOP-19952
> URL: https://issues.apache.org/jira/browse/HADOOP-19952
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Riya Khandelwal
> Assignee: Riya Khandelwal
> Priority: Minor
> Labels: pull-request-available
>
> Support Single EKU outbound certs by loading ssl.client.keystore.* when
> configured.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
