arhxam opened a new pull request, #8661:
URL: https://github.com/apache/hadoop/pull/8661

   ### Description of PR
   
   Fixes [HADOOP-19267](https://issues.apache.org/jira/browse/HADOOP-19267).
   
   `ShutdownHookManager#getShutdownTimeout` already clamps 
`hadoop.service.shutdown.timeout` to its one-second minimum, but it does so 
silently. A mistyped or incorrectly converted duration is therefore hard for an 
operator to diagnose.
   
   This patch emits a structured warning that identifies the configuration key, 
its value after conversion to seconds, the supported minimum, and the value 
Hadoop will use. The existing fallback behavior is unchanged.
   
   ### How was this patch tested?
   
   On macOS with OpenJDK 17.0.20 and Maven Wrapper 3.9.15:
   
   ```text
   ./mvnw -pl hadoop-common-project/hadoop-common -am -DskipShade \
     -Dtest=TestShutdownHookManager \
     -Dsurefire.failIfNoSpecifiedTests=false test
   
   Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
   BUILD SUCCESS
   ```
   
   The updated bad-configuration test captures the class logger and verifies 
both the clamped return value and the full diagnostic warning. Before the 
production change, the new log assertion fails.
   
   ### For code changes:
   
   - [x] Does the title of this PR start with the corresponding JIRA issue id?
   - [ ] Object storage: N/A
   - [ ] If adding new dependencies: no new dependencies
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files? N/A
   
   ### AI Tooling
   
   Contains content generated by Codex.
   
   - [x] The PR includes the phrase "Contains content generated by Codex"
   - [x] My use of AI contributions follows the ASF legal policy
         https://www.apache.org/legal/generative-tooling.html
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to