Hexiaoqiao commented on code in PR #8659:
URL: https://github.com/apache/hadoop/pull/8659#discussion_r3772357441
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java:
##########
@@ -227,9 +227,10 @@ public void testIsClusterUpAfterShutdown() throws
Throwable {
dfs.setSafeMode(SafeModeAction.ENTER);
cluster4.shutdown();
} finally {
+ cluster4.shutdown();
Review Comment:
shutdown `cluster4` twice here.
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/TestNNWithQJM.java:
##########
@@ -36,12 +36,16 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.Timeout;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;
public class TestNNWithQJM {
+ private static final Logger LOG =
Review Comment:
This logger aren't used anymore？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
