pan3793 opened a new pull request, #8688:
URL: https://github.com/apache/hadoop/pull/8688

   ### Description of PR
   
   ZKDelegationTokenSecretManager reads the CuratorCache immediately after
   starting it, but CuratorCache populates asynchronously, so the cache can
   still be empty and existing tokens/keys are silently not loaded into memory
   on startup. It also created the root container znodes data-less, which
   Curator 5.2.0+ defaults to the local address, so the container znode data
   could not be parsed.
   
   This change:
   - Waits for CuratorCache initialization (forInitialized) before loading each 
cache.
   - Skips the root container znode (/ZKDTSMMasterKeyRoot, /ZKDTSMTokensRoot)
     when processing cache events and when streaming the cache, since it is a
     container rather than a key/token.
   - Creates the root container znodes with explicit empty data.
   - Restores the thread-local curator and closes the client in the tests that
     use setCurator, and waits for the good token to load in
     testNodesLoadedAfterRestart.
   
   Contains content generated by deepseek-v4-pro
   
   ### How was this patch tested?
   
   mvn -pl hadoop-common-project/hadoop-common -am \
     -Dtest=TestZKDelegationTokenSecretManager test
   
   ### For code changes:
   
   - [x] Does the title of this PR start with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: Have the integration tests been executed and the 
endpoint
         declared according to the connector-specific documentation? *Note: 
Automated CI
         testing doesn't cover all cases so manual testing with cloud storage 
is still
         required.*
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   ### AI Tooling
   
   If an AI tool was used:
   
   - [x] The PR includes the phrase "Contains content generated by <tool>"
         where <tool> is the name of the AI tool used.
   - [x] My use of AI contributions follows the ASF legal policy
         https://www.apache.org/legal/generative-tooling.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to