pan3793 commented on code in PR #8682:
URL: https://github.com/apache/hadoop/pull/8682#discussion_r3811369877
##########
hadoop-common-project/hadoop-common/pom.xml:
##########
@@ -541,12 +541,6 @@
<systemPropertyVariables>
<runningWithNative>${runningWithNative}</runningWithNative>
</systemPropertyVariables>
- <properties>
- <property>
- <name>listener</name>
- <value>org.apache.hadoop.test.TimedOutTestsListener</value>
Review Comment:
I'd reconsider the ServiceLoader approach entirely. Auto-registration leaks
into
any downstream JUnit Platform run with the test-jar on its test classpath,
which
is the side effect called out in the PR body. An explicit, per-module
registration
avoids that: Surefire's `listener` provider property. It currently accepts
only
JUnit 4 `RunListener`; `TestExecutionListener` support is tracked as
[SUREFIRE-1639](https://issues.apache.org/jira/browse/SUREFIRE-1639) (open
since
2019). Keeping the `listener` property here (once surefire supports
`TestExecutionListener`) would give the same "wider net" without the
downstream
leakage, at the cost of per-pom wiring.
I have opened https://github.com/apache/maven-surefire/pull/3438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
