[ 
https://issues.apache.org/jira/browse/HADOOP-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413436#comment-13413436
 ] 

Ivan Mitic commented on HADOOP-8457:
------------------------------------

Thanks for comments Sanjay. 

bq. Does not make sense to expose a low level structure like ugi through a 
fundamental class like FileStatus. Make the parameter String user.
I saw that FileSystem already had an API that accepts UGI 
({{FileSystem#closeAllForUGI())}}, that is why I thought this is fine. On the 
other hand, I didn't want to expose this on the FileSystem, as it would require 
for a caller to query the FileSystem twice if it wants to check both ownership 
and permissions.

bq. Is there another way to solve the problem in a simple way without adding 
such a method? 
Exposing it through the API makes it easier to specialize through 
RawLocalFileStatus as you noted. Yes, we could expose this functionality as a 
Util function. However, it would only do the Administrators group check if 
{{FileSystem}} is {{instanceof LocalFileSystem}} (and on Windows). Do you 
believe this would be more appropriate?

                
> Address file ownership issue for users in Administrators group on Windows.
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-8457
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8457
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 1.1.0, 0.24.0
>            Reporter: Chuan Liu
>            Assignee: Ivan Mitic
>            Priority: Minor
>         Attachments: HADOOP-8457-branch-1-win_Admins(2).patch, 
> HADOOP-8457-branch-1-win_Admins.patch
>
>
> On Linux, the initial file owners are the creators. (I think this is true in 
> general. If there are exceptions, please let me know.) On Windows, the file 
> created by a user in the Administrators group has the initial owner 
> ‘Administrators’, i.e. the the Administrators group is the initial owner of 
> the file. As a result, this leads to an exception when we check file 
> ownership in SecureIOUtils .checkStat() method. As a result, this method is 
> disabled right now. We need to address this problem and enable the method on 
> Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to