pan3793 commented on code in PR #8699:
URL: https://github.com/apache/hadoop/pull/8699#discussion_r3860353870
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java:
##########
@@ -141,24 +145,24 @@ protected boolean notifyURLOnce() {
private boolean notifyViaBuiltInNotifier() {
boolean success = false;
try {
- Log.getLog().info("Job end notification trying " + urlToNotify);
+ LOG.info("Job end notification trying " + urlToNotify);
HttpURLConnection conn =
(HttpURLConnection) urlToNotify.openConnection(proxyToUse);
conn.setConnectTimeout(timeout);
conn.setReadTimeout(timeout);
conn.setAllowUserInteraction(false);
if(conn.getResponseCode() != HttpURLConnection.HTTP_OK) {
- Log.getLog().warn("Job end notification to " + urlToNotify
+ LOG.warn("Job end notification to " + urlToNotify
+ " failed with code: " + conn.getResponseCode() + " and message
\""
+ conn.getResponseMessage() + "\"");
}
else {
success = true;
- Log.getLog().info("Job end notification to " + urlToNotify
+ LOG.info("Job end notification to " + urlToNotify
Review Comment:
please also change it to `{}` placeholder style, and I think
`org.eclipse.jetty.util.log.Log` => `org.slf4j.Logger` worth a dedicated PR and
we can do a backport
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
