[
https://issues.apache.org/jira/browse/HADOOP-19971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18110380#comment-18110380
]
ASF GitHub Bot commented on HADOOP-19971:
-----------------------------------------
hadoop-yetus commented on PR #8703:
URL: https://github.com/apache/hadoop/pull/8703#issuecomment-5497964858
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 21m 30s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 4 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 2m 19s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 55m 31s | | trunk passed |
| +1 :green_heart: | compile | 22m 1s | | trunk passed with JDK
Ubuntu-21.0.12+8-1-24.04-Ubuntu |
| +1 :green_heart: | compile | 20m 57s | | trunk passed with JDK
Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| +1 :green_heart: | checkstyle | 6m 5s | | trunk passed |
| +1 :green_heart: | mvnsite | 20m 29s | | trunk passed |
| +1 :green_heart: | javadoc | 11m 28s | | trunk passed with JDK
Ubuntu-21.0.12+8-1-24.04-Ubuntu |
| +1 :green_heart: | javadoc | 11m 21s | | trunk passed with JDK
Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| +0 :ok: | spotbugs | 0m 20s | | branch/hadoop-project no spotbugs
output file (spotbugsXml.xml) |
| -1 :x: | spotbugs | 46m 30s |
[/branch-spotbugs-root-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8703/3/artifact/out/branch-spotbugs-root-warnings.html)
| root in trunk has 93 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 31s | |
branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file
(spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 27s | |
branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file
(spotbugsXml.xml) |
| -1 :x: | spotbugs | 0m 49s |
[/branch-spotbugs-hadoop-tools_hadoop-resourceestimator-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8703/3/artifact/out/branch-spotbugs-hadoop-tools_hadoop-resourceestimator-warnings.html)
| hadoop-tools/hadoop-resourceestimator in trunk has 12 extant spotbugs
warnings. |
| -1 :x: | spotbugs | 2m 3s |
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8703/3/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html)
|
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
in trunk has 1 extant spotbugs warnings. |
| +1 :green_heart: | shadedclient | 34m 14s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 34m 45s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 81m 32s | | the patch passed |
| +1 :green_heart: | compile | 20m 40s | | the patch passed with JDK
Ubuntu-21.0.12+8-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 20m 40s | | the patch passed |
| +1 :green_heart: | compile | 20m 39s | | the patch passed with JDK
Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 20m 39s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 6m 16s | | root: The patch generated
0 new + 37 unchanged - 1 fixed = 37 total (was 38) |
| +1 :green_heart: | mvnsite | 20m 29s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | javadoc | 11m 3s | | the patch passed with JDK
Ubuntu-21.0.12+8-1-24.04-Ubuntu |
| +1 :green_heart: | javadoc | 11m 14s | | the patch passed with JDK
Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| +0 :ok: | spotbugs | 0m 21s | | hadoop-project has no data from
spotbugs |
| +0 :ok: | spotbugs | 0m 28s | |
hadoop-client-modules/hadoop-client-runtime has no data from spotbugs |
| +0 :ok: | spotbugs | 0m 25s | |
hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs |
| -1 :x: | shadedclient | 78m 17s | | patch has errors when building
and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 883m 13s |
[/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8703/3/artifact/out/patch-unit-root.txt)
| root in the patch failed. |
| +1 :green_heart: | asflicense | 1m 53s | | The patch does not
generate ASF License warnings. |
| | | 1488m 49s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests |
hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService
|
| | hadoop.yarn.server.router.webapp.TestRouterWebServicesREST |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.55 ServerAPI=1.55 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8703/3/artifact/out/Dockerfile
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
shellcheck shelldocs |
| uname | Linux 4e75d000b85a 5.15.0-185-generic #195-Ubuntu SMP Fri Jun 19
17:11:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / abbc78d44168ead0a604b49b195fe677931a8cd2 |
| Default Java | Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12+8-1-24.04-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8703/3/testReport/ |
| Max. process+thread count | 4209 (vs. ulimit of 10000) |
| modules | C: hadoop-project hadoop-common-project/hadoop-auth
hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common
hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms
hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs
hadoop-hdfs-project/hadoop-hdfs-nfs
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-mapreduce-project/hadoop-mapreduce-client
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp
hadoop-mapreduce-project/hadoop-mapreduce-examples
hadoop-tools/hadoop-resourceestimator
hadoop-client-modules/hadoop-client-runtime
hadoop-client-modules/hadoop-client-minicluster . U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8703/3/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 shellcheck=0.9.0 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Remove servlet and Jetty types from classes that do not need them
> -----------------------------------------------------------------
>
> Key: HADOOP-19971
> URL: https://issues.apache.org/jira/browse/HADOOP-19971
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: auth, common
> Reporter: Jose Luis López
> Priority: Minor
> Labels: pull-request-available
>
> WHY
> ===
> Hadoop will eventually move from the javax.servlet namespace to
> jakarta.servlet. When it does, every class that mentions a servlet type has to
> be revisited, and every class that mentions a Jetty type has to be revisited
> again when the Jetty API changes underneath it.
> Several of those classes have no real connection to either. A component that
> generates signing secrets was handed the web server's context even though it
> only wanted somewhere to stash an object. A certificate parser reported a bad
> certificate as a web server error. A file-transfer handler built on Netty
> borrowed two header names from Jetty.
> This clears those cases out. The later migration is smaller, and the classes
> concerned stop being part of it at all.
> WHAT CHANGES FOR ANYONE USING HADOOP
> ====================================
> Nothing. Nothing is removed, nothing changes shape, and no dependency, version
> or setting changes. Code built against today's release keeps compiling and
> keeps running without being rebuilt.
> Two entry points were the awkward ones. Both stay exactly as they are, marked
> deprecated, with a cleaner alternative alongside. Projects that adopt the new
> one are unaffected when the namespace finally moves; projects that do not are
> no worse off than today. A test suite exists purely to prove the old path
> still
> behaves - including the awkward case of a plugin that extends Hadoop's rolling
> secret provider and calls up into it.
> The shuffle protocol is untouched, byte for byte. Deployments see no
> difference.
> WHAT CHANGES INSIDE
> ===================
> before after
> modules using Jetty in main sources 13 12
> main-source files using Jetty 25 23
> hadoop-auth main classes naming a servlet 14 11
> The MapReduce shuffle module stops depending on Jetty altogether, in code and
> in its build file.
> In hadoop-auth, the secret providers and the authentication token no longer
> mention the servlet API. They are initialised instead against a small,
> two-method store that holds whatever needs sharing - which is all the one
> provider that used the servlet context was ever doing with it. One new class
> does mention the servlet API, and exists solely to keep the old path working.
> The YARN services client and the shuffle handler each replaced a small Jetty
> utility with the equivalent from the JDK or from Netty, which they already
> depend on.
> WHAT THIS DOES NOT DO
> =====================
> No namespace change, no Jetty upgrade, no Jersey change, no EE environments.
> The tree stays on Jetty 9.4, Jersey 2 and javax.servlet throughout.
> The authentication handler classes still mention the servlet API,
> deliberately.
> They sit on the extension point that HBase, Hive, Spark, Ozone and Knox build
> against, and changing it is precisely the kind of break this issue is designed
> to avoid. It belongs with the namespace change, where downstream projects are
> expecting it.
> DEPENDS ON
> ==========
> HADOOP-19970 (PR #8699), for sequencing only. That PR declares a Jetty
> artifact
> for the shuffle module; this one removes the last use of it, and drops the
> declaration in the same change.
> 16 files changed. Works whether HADOOP-19912 ends up going through Jetty 12's
> ee8 environment or straight to ee10, and commits the project to neither.
> Contains content generated by Claude.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
