joseluisll commented on code in PR #8717:
URL: https://github.com/apache/hadoop/pull/8717#discussion_r3946985892
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java:
##########
@@ -264,7 +264,12 @@ private void verifyLocalFileDeletion(
GenericTestUtils.waitFor(() -> !f.exists(), 1000, 1000 * 50);
assertFalse(f.exists(), "File [" + f + "] was not deleted");
}
- assertFalse(app1LogDir.exists(), "Directory [" + app1LogDir + "] was not
deleted");
+ // DeletionService removes the files before the directories that hold
Review Comment:
Right, the two FileDeletionTasks are independent and either can run first —
reworded. Collapsed the four per-file waits into the single wait on app1LogDir,
and moved the message into the 4-arg waitFor for the unreachable-assertion
reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
