[
https://issues.apache.org/jira/browse/HADOOP-7818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J updated HADOOP-7818:
----------------------------
Attachment: HADOOP-7818-4.patch
I improved a little bit on your patch.
# Capitalized all the thrown messages
# Removed some unnecessary whitespace around the changes I made
I kept the strace-print since its still a test.
I do not think the role tip is possible, given this is a common class.
All tests pass, no other changes made:
{code}
Running org.apache.hadoop.util.TestDiskChecker
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.802 sec
{code}
> DiskChecker#checkDir should fail if the directory is not executable
> -------------------------------------------------------------------
>
> Key: HADOOP-7818
> URL: https://issues.apache.org/jira/browse/HADOOP-7818
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
> Reporter: Eli Collins
> Assignee: madhukara phatak
> Priority: Minor
> Attachments: HADOOP-7818-1.patch, HADOOP-7818-2.patch,
> HADOOP-7818-3.patch, HADOOP-7818-4.patch, HADOOP-7818.patch
>
>
> DiskChecker#checkDir fails if a directory can't be created, read, or written
> but does not fail if the directory exists and is not executable. This causes
> subsequent code to think the directory is OK but later fail due to an
> inability to access the directory (eg see MAPREDUCE-2921). I propose checkDir
> fails if the directory is not executable. Looking at the uses, this should be
> fine, I think it was ignored because checkDir is often used to create
> directories and it creates executable directories.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
