sankalpsthakur opened a new pull request, #8746: URL: https://github.com/apache/hadoop/pull/8746
Fixes [HADOOP-7856](https://issues.apache.org/jira/browse/HADOOP-7856) ### Description of PR `DiskChecker#checkDir(File)` javadocs were incomplete (the original summary trailed off, and later checkstyle-only `@param`/`@throws` text did not describe the method). Switching between `checkDir(File)` and `checkDir(LocalFileSystem, Path, FsPermission)` can also surprise callers: File-based access checks reflect OS/filesystem writability, while Hadoop `FsPermission` / `FsAction#implies` only inspect permission bits and can pass on a read-only filesystem. This change completes the `checkDir` javadocs and calls that distinction out explicitly. After HADOOP-8973 both overloads also use `File` methods for access; the FsPermission overload still additionally applies `expected` permission, so the two APIs remain not equivalent. Javadoc-only. No code behavior change. ### How was this patch tested? Checks in progress (will update this PR with results): - `TestDiskChecker` / `TestDiskCheckerWithDiskIo` - checkstyle on the touched file if feasible ### For code changes: - [x] Does the title of this PR start with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: N/A - [ ] New dependencies: none - [ ] LICENSE/NOTICE: N/A ### AI Tooling - [x] The PR includes the phrase "Contains content generated by Cursor Grok 4.6" - [x] My use of AI contributions follows the ASF legal policy https://www.apache.org/legal/generative-tooling.html Contains content generated by Cursor Grok 4.6. ### Contributor notes - Apache ICLA may be required for this contribution. I am **not** claiming that an ICLA has been signed. - Please do not merge until a committer has confirmed CLA status and reviewed the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
