[
https://issues.apache.org/jira/browse/HADOOP-19805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18116946#comment-18116946
]
ASF GitHub Bot commented on HADOOP-19805:
-----------------------------------------
deepujain opened a new pull request, #8305:
URL: https://github.com/apache/hadoop/pull/8305
### Description of PR
Pass the caller's Hadoop configuration to custom HTTP signers that implement
`Configurable`. `SignerFactory.createHttpSigner` currently constructs the
signer without calling `setConf`, so it cannot read that configuration.
This follows up on HADOOP-19805, which is already resolved. **A separate
JIRA ticket is pending creation; HADOOP-19805 is historical context, not the
tracking ticket for this follow-up.**
### How was this patch tested?
The diff includes
`TestSignerManager.testCreateHttpSignerSetsConfWhenConfigurable`, which checks
that a configurable HTTP signer receives the same configuration instance
supplied to the factory.
### Evidence it works
Historical Yetus feedback is available in this PR. Tests have not been rerun
as part of reopening the PR, and this metadata update does not claim validation
against current trunk. No object-store endpoint was exercised during this
update.
### For code changes:
- [ ] The title starts with the replacement JIRA issue ID (pending ticket
creation).
- [ ] Object storage integration tests have been executed and the endpoint
declared.
- No dependencies or license files are changed.
### AI Tooling
Contains content generated by Codex.
> When creating a signer, if it is Configurable, set its config
> -------------------------------------------------------------
>
> Key: HADOOP-19805
> URL: https://issues.apache.org/jira/browse/HADOOP-19805
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.4.3
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.5.0, 3.4.3
>
>
> When creating a signer for s3 (or another service), if it is Configurable,
> call setConf() on it.
> This comes from me wiring s3a up to iceberg RestCatalog; it's pretty
> convoluted to connect a signer in the sdk to its owner fs otherwise, and so
> get the configuration for that bucket. Trivial change.
> (w.r.t the old convolutedness: a v1 issue). For v2 we can create and
> configure the signer then attach it: nothing else needed!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
