steveloughran commented on code in PR #8307:
URL: https://github.com/apache/hadoop/pull/8307#discussion_r4112000780
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java:
##########
@@ -560,4 +561,26 @@ public void testSuffixFromRoot() {
assertNull(root.getParent());
assertEquals(new Path("/bar"), root.suffix("bar"));
}
+
+ /**
+ * HADOOP-19815: Path(String) strips trailing slash; Path(URI) preserves it.
+ * So URI.resolve() behavior differs: String-constructed dir path resolves
+ * "x" to host/x; URI-constructed dir path resolves "x" to host/dir/x.
+ */
+ @Test
+ @Timeout(value = 30)
+ public void testTrailingSlashAndUriResolve() throws URISyntaxException {
Review Comment:
this is the main change then, a new test case? The others are a partial move
of existing test cases to move from junit assert to assertj?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
