shoemoney commented on code in PR #8705:
URL: https://github.com/apache/hadoop/pull/8705#discussion_r4121868779
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java:
##########
@@ -332,7 +332,7 @@ private void uploadLogsForContainers(boolean appFinished)
LOG.debug("Cycle #{} of log aggregator", logAggregationTimes);
String diagnosticMessage = "";
boolean logAggregationSucceedInThisCycle = true;
- DeletionTask deletionTask = null;
+ List<DeletionTask> deletionTasks = new ArrayList<>();
Review Comment:
Added in 040fa443:
`testAggregatorDeletesUploadedLogsOfEveryContainerInACycle` starts two
containers with distinct log files in one aggregation cycle and asserts the
uploaded files of both are scheduled for deletion. Verified RED against the
single-variable implementation (only the last container's files were scheduled)
and GREEN with this patch. Details in the PR comment below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
