[
https://issues.apache.org/jira/browse/HADOOP-19995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18121620#comment-18121620
]
ASF GitHub Bot commented on HADOOP-19995:
-----------------------------------------
joseluisll opened a new pull request, #8772:
URL: https://github.com/apache/hadoop/pull/8772
### Description of PR
JIRA: https://issues.apache.org/jira/browse/HADOOP-19995
HADOOP-19731 added `dev-support/findbugs-exclude-global.xml` and connected
it to the
`spotbugs-maven-plugin` configuration of about 30 modules, but
`hadoop-resourceestimator`
was left out. It is the only `hadoop-tools` module with no spotbugs plugin
configuration
of its own. It therefore uses the root plugin with no exclude filters, so
`CT_CONSTRUCTOR_THROW` and `EI_EXPOSE_REP` / `EI_EXPOSE_REP2` findings count
as errors.
Any precommit run that touches this module fails because of them (for example
apache/hadoop#8704 / HADOOP-19972).
This PR adds the `spotbugs-maven-plugin` configuration to
`hadoop-tools/hadoop-resourceestimator/pom.xml`. It points at the shared
global exclude
file in the same way as the sibling modules (`xmlOutput=true`,
`excludeFilterFile=${maven.multiModuleProjectDirectory}/dev-support/findbugs-exclude-global.xml`).
Only the build configuration changes. There are no Java source changes.
### How was this patch tested?
Ran locally:
mvn -pl hadoop-tools/hadoop-resourceestimator compile spotbugs:check
- Before the change: 12 bugs reported, BUILD FAILURE
- After the change: 0 findings, BUILD SUCCESS
Module unit tests: 47 run, 0 failures, 0 errors.
### For code changes:
- [x] Does the title of this PR start with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: Have the integration tests been executed and the
endpoint
declared according to the connector-specific documentation? — N/A, no
object store connector touched.
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)? — N/A, no new
dependencies.
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files? — N/A.
### AI Tooling
If an AI tool was used:
- [x] The PR includes the phrase "Contains content generated by Claude Code"
where <tool> is the name of the AI tool used.
- [x] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
Contains content generated by Claude Code.
> Fix the trunk SpotBugs warnings in hadoop-resourceestimator
> -----------------------------------------------------------
>
> Key: HADOOP-19995
> URL: https://issues.apache.org/jira/browse/HADOOP-19995
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Jose Luis López
> Assignee: Jose Luis López
> Priority: Major
>
> Spotbugs reports warnings on trunk in
> {{hadoop-tools/hadoop-resourceestimator}}:
> * {{org.apache.hadoop.resourceestimator.service.ResourceEstimatorService}}:
> CT_CONSTRUCTOR_THROW
> * {{org.apache.hadoop.resourceestimator.common.api.ResourceSkyline}}:
> EI_EXPOSE_REP, EI_EXPOSE_REP2
> * {{org.apache.hadoop.resourceestimator.translator.api.JobMetaData}}:
> EI_EXPOSE_REP, EI_EXPOSE_REP2
> * {{org.apache.hadoop.resourceestimator.solver.impl.LpSolver}}: EI_EXPOSE_REP2
> * {{org.apache.hadoop.resourceestimator.translator.impl.BaseLogParser}}:
> EI_EXPOSE_REP2
> It turns the precommit of pull requests that do not touch it red:
> * [PR #8704|https://github.com/apache/hadoop/pull/8704] (HADOOP-19972)
> Seen in: precommit; first seen 2026-08-25, last seen 2026-09-27.
> Report:
> https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8704/20/artifact/out/branch-spotbugs-hadoop-tools_hadoop-resourceestimator-warnings.html
> No open pull request or JIRA issue that fixes it was found.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
