Abhi0505-kinagi commented on PR #8764: URL: https://github.com/apache/hadoop/pull/8764#issuecomment-5949053571
Thanks for the review @joseluisll . I've pushed an update, squashed into one commit titled `YARN-11991. Fix counting virtual memory in cgroup v2`. ### Blocking items - [x] Removed both `.save` files. - [x] Fixed the indentation on `getVirtualMemorySize`, the `calculateVirtualMemory` overrides and the abstract declaration, and added a blank line after the constructor. Checkstyle shows no new violations in the touched files. - [x] Squashed the commits and restored the title `YARN-11991. Fix counting virtual memory in cgroup v2`. ### Suggestions - [x] Added javadoc on `calculateVirtualMemory()`. - [ ] Missing-swap test: not in this push. I'll follow up on it separately. - [ ] Release note: not in this push. Suggested text, if a committer could add it to the Release Note field on YARN-11991: "Clusters that configure `CGroupsV2ResourceCalculator` directly with `yarn.nodemanager.vmem-check-enabled=true` now compare anon + swap against `pmem * vmem-pmem-ratio`. Before, only swap was counted, so the check almost never fired. The default `CombinedResourceCalculator` is unaffected." ### Testing Ran all tests in the `linux/resources` package locally: | Result | Count | |---|---| | Tests run | 57 | | Failures | 0 | | Errors | 0 | | Skipped | 1 (`TestCompareResourceCalculators`, no cgroup environment here) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
