joseluisll opened a new pull request, #8782: URL: https://github.com/apache/hadoop/pull/8782
### Description of PR [YARN-12001](https://issues.apache.org/jira/browse/YARN-12001). **This changes production code** in `TimelineReaderServer`. - `TestTimelineReaderHBaseDown` starts a `TimelineReaderServer` in all five tests and never stops it. Each test leaks the `TimelineStorageMonitor`'s non-daemon polling thread, which keeps polling a minicluster that has already shut down. The module runs with `forkCount` 0, so these threads pile up in Maven's JVM. The tests now stop the server in a `finally` with `ServiceOperations.stopQuietly()`, as the other tests in the module do. `testTimelineReaderRecoversAfterHBaseReturns` now waits for regions in transition before shutting down. `configure()` replaces `hbase.regionserver.abort.timeout.task` with a no-op, because HBase's default halts the JVM, which here is Maven's. - `TimelineReaderServer.serviceStop()` now calls `super.serviceStop()` in a `finally`. Before, if `HttpServer2.stop()` threw, the reader and the storage monitor were never stopped. The web-app stop moves into a `@VisibleForTesting` `stopTimelineReaderWebApp()`. - New regression test: `TestTimelineReaderServer#testChildServicesStoppedWhenWebAppStopFails`. ### How was this patch tested? - `TestTimelineReaderServer`: 4/4 pass. The new test fails without the `serviceStop()` change (`FileSystemTimelineReaderImpl` left `STARTED`). - `TestTimelineReaderHBaseDown`: 5/5 pass, none skipped. - Leak check: a temporary probe run right after `TestTimelineReaderHBaseDown` in the same JVM found 5 live non-daemon `TimelineStorageMonitor` threads on trunk and 0 with this patch. - Checkstyle: no new issues in the changed files. ### For code changes: - [x] Does the title of this PR start with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: Have the integration tests been executed and the endpoint declared according to the connector-specific documentation? *(N/A)* - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0? *(N/A, no new dependencies)* - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? *(N/A)* ### AI Tooling - [x] The PR includes the phrase "Contains content generated by <tool>" where <tool> is the name of the AI tool used. - [x] My use of AI contributions follows the ASF legal policy https://www.apache.org/legal/generative-tooling.html Contains content generated by Claude Code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
