[ 
https://issues.apache.org/jira/browse/HADOOP-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415821#comment-13415821
 ] 

Bikas Saha commented on HADOOP-8453:
------------------------------------

Sorry! I incorrectly remembered that this was a JUnit test. Having it as a 
junit test will let it work properly with the rest of test/reporting. Eg. tell 
you how many tests failed etc.
I think we should exec the bat script inside a junit testcase when the OS is 
windows. We could do that as part of 8601 or even remove these bat scripts if 
those new testcases cover the ones in the bat script. +1.
                
> Add unit tests for winutils
> ---------------------------
>
>                 Key: HADOOP-8453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8453
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: test
>    Affects Versions: 1.1.0, 0.24.0
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>         Attachments: HADOOP-8453-branch-1-win-2.patch, 
> HADOOP-8453-branch-1-win.patch
>
>
> In [Hadoop-8235|https://issues.apache.org/jira/browse/HADOOP-8235], we 
> created a Windows console program, named ‘winutils’, to emulate some Linux 
> command line utilities used by Hadoop. However no tests are provided in the 
> original patch. As this code is quite complicated, and the complexity may 
> even grow up in the future. We think unit tests are necessary to ensure code 
> quality, as well as smooth future development.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to