vt921102 commented on PR #8693:
URL: https://github.com/apache/hadoop/pull/8693#issuecomment-6008079118
Hi @anujmodi2021,
Could you help get this backport merged into `branch-3.4`? HADOOP-19973 has
fix
versions 3.4.4 and 3.5.1, and the trunk change is already in via #8536.
Current state:
- Refreshed onto the current `branch-3.4` head, as a cherry-pick of
`e8783aa59255e86f37dcb8c5cc629821638052c0`.
- `Apache Yetus` is **+1 overall** with no negative rows, including
`+1 unit — hadoop-azure in the patch passed` and `+1 asflicense`.
`continuous-integration/jenkins/pr-merge` is green.
- The production change in `AbfsClient.java` is byte-identical to the trunk
commit.
- `TestAbfsClient.java` is the one place this differs from trunk, because
`branch-3.4` is still on JUnit 4: it uses `Assertions.assertThat` and
`Mockito.spy`, its `AbfsDfsClient` constructor takes six arguments, and its
`AbfsClientContextBuilder` has no `withFileSystemId`. That is the only
divergence, and it is why this cannot be a byte-identical cherry-pick.
- The `Build` check shows `action_required` because
`.github/workflows/build_and_test.yml` was added to trunk by HADOOP-19858
on
2026-04-22, after `branch-3.4` was cut. No run of that workflow can exist
for
this branch, so the check is unsatisfiable here; it affects every PR
against
`branch-3.4`/`branch-3.5`.
On validations: the full `hadoop-azure` integration suite was run against a
live
ADLS endpoint for the trunk PR and the results are reported in #8536. Since
the
production change here is identical, would you like me to repeat that run
against
`branch-3.4` before you merge, or is the trunk run sufficient? I am happy to
rerun
it — just confirming what you need, as it requires booking time on our
storage
account.
#8692 for `branch-3.5` is in the same state and also green, in case it is
easier
to take the two together.
Thanks for your help with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
