joseluisll opened a new pull request, #8814:
URL: https://github.com/apache/hadoop/pull/8814

   ### Description of PR
   
   JIRA: https://issues.apache.org/jira/browse/YARN-12023
   
   `BaseSharingPolicyTest#generateRLEAlloc` folded a reservation onto its 
period starting at `initTime % period`, with `initTime` taken from the wall 
clock. Its wrap-around arithmetic dropped one full period whenever the rest of 
the duration wrapped past the end of the period. For example, a 25h reservation 
on a 1-day period produced only about 1h of allocation when the test ran 
between 23:00 and 24:00 UTC, so the expected `PlanningQuotaException` for that 
case was never thrown.
   
   This change:
   - Generates `floor(duration / period)` full periods plus the remainder, 
starting at `initTime % period` and wrapping when needed, so the generated 
allocation always adds up to `duration`.
   - Uses a fixed `initTime`. At a few specific times of day, 
`PeriodicRLESparseResourceAllocation#getRangeOverlapping` can return an 
open-ended allocation when a step lands exactly on the range end (tracked 
separately as YARN-12022). `CapacityOverTimePolicy` then rejects some cases for 
that reason instead of the one under test.
   
   This is a test-only change in `BaseSharingPolicyTest`, which affects 
`TestCapacityOverTimePolicy` and `TestNoOverCommitPolicy`.
   
   ### How was this patch tested?
   
   Test-only change; covered by `TestCapacityOverTimePolicy` and 
`TestNoOverCommitPolicy` in `hadoop-yarn-server-resourcemanager`.
   
   ### For code changes:
   
   - [x] Does the title of this PR start with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: Have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation? (N/A)
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? (N/A, no new 
dependencies)
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files? (N/A)
   
   ### AI Tooling
   
   - [x] The PR includes the phrase "Contains content generated by <tool>" 
where <tool> is the name of the AI tool used.
   - [ ] My use of AI contributions follows the ASF legal policy 
https://www.apache.org/legal/generative-tooling.html
   
   Contains content generated by Claude Code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to