gerashegalov opened a new pull request, #8817: URL: https://github.com/apache/hadoop/pull/8817
### Description of PR `UnitsConversionUtil.convert` can overflow during intermediate multiplication even when the final result fits in a `long`. For example, converting `Long.MAX_VALUE` from `p` to `G` returns `2` instead of `0`, while converting `10000` from `P` to `Pi` throws instead of returning `8881`. Use checked `long` arithmetic for the common path and `BigInteger` when an intermediate overflows. Reject only a final result outside `long`. Zero values return before multiplication, after unit validation. This change does not alter `compare`. Contains content generated by OpenAI Codex. ### How was this patch tested? - Targeted Maven tests for `TestUnitsConversionUtil`, `TestResourceUtils`, `TestTimelineServiceHelper`, and `TestResourcePBImpl`: 33 tests passed, no failures or errors. - `git diff --check` passed. - An independent arithmetic review checked all 225 unit pairs across 16,461 inputs with no mismatches. ### For code changes: - [x] Does the title of this PR start with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: Have the integration tests been executed and the endpoint declared according to the connector-specific documentation? *Note: Automated CI testing doesn't cover all cases so manual testing with cloud storage is still required.* (Not applicable.) - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? (No new dependencies.) - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? (Not applicable.) ### AI Tooling If an AI tool was used: - [x] The PR includes the phrase "Contains content generated by <tool>" where <tool> is the name of the AI tool used. - [ ] My use of AI contributions follows the ASF legal policy https://www.apache.org/legal/generative-tooling.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
