brumi1024 commented on code in PR #8802: URL: https://github.com/apache/hadoop/pull/8802#discussion_r4263721490
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/QueueHierarchyTransitionChecks.java: ########## @@ -0,0 +1,212 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity; + +import org.apache.hadoop.classification.InterfaceAudience; +import org.apache.hadoop.classification.InterfaceStability; +import org.apache.hadoop.yarn.api.records.QueueState; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Checks of the transition from the existing queue hierarchy to a newly configured one: + * queue removal, moves and conversions between leaf, parent and auto create enabled parent + * queues. Every check compares an existing queue with its counterpart in the new hierarchy and + * returns null when it passes, or the error message when it fails; the caller decides which + * exception to throw. + */ [email protected] [email protected] +public final class QueueHierarchyTransitionChecks { + private static final Logger LOG = LoggerFactory.getLogger( Review Comment: Yes, deliberate, to keep the log category of that warning. Added a comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
