joseluisll commented on code in PR #8805:
URL: https://github.com/apache/hadoop/pull/8805#discussion_r4279977354
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##########
@@ -943,8 +944,15 @@ public void run() {
}
}
} catch (Throwable t) {
+ if (!running) {
+ // stopThreads() interrupts this thread, which can surface as an
+ // exception from the backing store; don't kill the process for it.
+ LOG.warn("ExpiredTokenRemover thread received exception while"
+ + " stopping", t);
+ return;
+ }
LOG.error("ExpiredTokenRemover thread received unexpected exception",
t);
- Runtime.getRuntime().exit(-1);
+ ExitUtil.terminate(-1, t);
Review Comment:
Thanks, agreed it's out of scope here. Filed HADOOP-20022 to switch
SecurityUtil.doAsLoginUserOrFatal to ExitUtil.terminate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
