joseluisll commented on PR #8806:
URL: https://github.com/apache/hadoop/pull/8806#issuecomment-6203462616
Pushed one change: the RBF
`TestZKDelegationTokenSecretManagerImpl.tearDown()`
now resets the Curator in a `finally` block, so a failing
`super.tearDown()` doesn't leak a STOPPED Curator into the next test.
This moved here from #8805 (HADOOP-20010), where it no longer belonged.
Coordination with related PRs:
- `testCreatingParentContainersIfNeeded` and `testMultipleInit` are
intentionally not touched here. #8688 (HADOOP-19966) already moves their
cleanup into `finally` blocks, and changing them here too would conflict.
- With #8688, a failed `init()` cleans up inside `startThreads()`, and the
`finally` blocks here then call `destroy()` again. That second stop is
harmless and keeps this PR correct on its own.
- #8805 makes `TestZKDelegationTokenSecretManager` fail a test if a leaked
remover thread calls `ExitUtil.terminate`, so any leak that slips past
these `finally` blocks shows up as a test failure instead of a crashed
fork.
All three PRs merge cleanly in any order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
