Hean-Chhinling commented on PR #8798: URL: https://github.com/apache/hadoop/pull/8798#issuecomment-6270222185
Thank you so much, @joseluisll @K0K0V0K and @slfan1989 for all your feedback. My bad to overlook on these issues. Since you all raised similar concern so I am going to put everything here. 1. **Configured directory skipped when owned by another user** issue has been fixed. The configured directory is now always checked and walked into, regardless of whoever owns it. The ownership rules apply only to entries below it. 2. **Owner compared by String user name**: owners are now compared as `UserPrincipal` objects, looked up from user.name. That works on Unix and Windows, e.g. `nmuser` vs `EXAMPLEDOMAIN\nmuser.` 3. **Usercache under the LinuxContainerExecutor:** skipping it wasn't intended. Directories owned by other users no longer need to be writable. They're walked into if the NodeManager user can read and enter them, and skipped otherwise. Files owned by other users are not checked. Entries owned by the NodeManager user keep the full check. This is all have been documented in `yarn-default.xml`. 4. **Max-depth:** it is validated when the configuration is read. A negative value fails with an error that names the property. I have added unit-tests to cover each of the above issues. Please let me know what do you think and whether other changes are necessary! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
